Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-uniform chunk sizes in formatting #57

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Handle non-uniform chunk sizes in formatting #57

merged 3 commits into from
Dec 20, 2024
+52 −9

Conversation

slevang
Copy link
Collaborator

@slevang slevang commented Dec 15, 2024

Closes #56.

@BSchilperoort BSchilperoort self-requested a review December 17, 2024 13:48
BSchilperoort
BSchilperoort previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

Looks good, but could you also update the changelog before you merge?

BSchilperoort
BSchilperoort approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the changelog entry, feel free to merge :)

@slevang slevang merged commit 7e51d9e into main Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utils.format_for_regrid requires uniform chunk sizes
2 participants
@slevang @BSchilperoort